codecparsers: vc1: fix PTYPE for interlaced frames.
authorGwenole Beauchesne <gwenole.beauchesne@intel.com>
Mon, 19 Nov 2012 09:32:57 +0000 (10:32 +0100)
committerGwenole Beauchesne <gwenole.beauchesne@intel.com>
Mon, 19 Nov 2012 12:57:48 +0000 (13:57 +0100)
Coverity found missing break in parse_frame_header_advanced() when
determining PTYPE from FPTYPE for interlaced streams.

https://bugzilla.gnome.org/show_bug.cgi?id=688626

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
gst-libs/gst/codecparsers/gstvc1parser.c

index 4ec9788..3c2640e 100644 (file)
@@ -924,30 +924,38 @@ parse_frame_header_advanced (GstBitReader * br, GstVC1FrameHdr * framehdr,
         case 0x00:
         case 0x02:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_I;
+          break;
         case 0x01:
         case 0x03:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_P;
+          break;
         case 0x04:
         case 0x06:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_B;
+          break;
         case 0x05:
         case 0x07:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_BI;
+          break;
       }
     } else {
       switch (pic->fptype) {
         case 0x00:
         case 0x01:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_I;
+          break;
         case 0x02:
         case 0x03:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_P;
+          break;
         case 0x04:
         case 0x05:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_B;
+          break;
         case 0x06:
         case 0x07:
           framehdr->ptype = GST_VC1_PICTURE_TYPE_BI;
+          break;
       }
     }
   } else