Fix memory leak in connection_create when libnet init fails

Change-Id: I90d134ca5bae5be30d4943079de3d33f6cf6d0bd
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>

diff --git a/packaging/capi-network-connection.spec b/packaging/capi-network-connection.spec
index 7cb4339cd26e68b092c513dc0c08e0887c9acef3..fd19d28eb22493b02b49ae2656d12a833baaaff6 100755 (executable)
--- a/packaging/capi-network-connection.spec
+++ b/packaging/capi-network-connection.spec
@@ -1,6 +1,6 @@
 Name:          capi-network-connection
 Summary:       Network Connection library in TIZEN C API
-Version:       1.0.117
+Version:       1.0.118
 Release:       1
 Group:         System/Network
 License:       Apache-2.0

diff --git a/src/connection.c b/src/connection.c
index a00868f8303ece34d0f0844829414ba957f67a78..8b9f3a70f9ddb1a0222d336c48e81c7f8b5d86e5 100755 (executable)
--- a/src/connection.c
+++ b/src/connection.c
@@ -169,10 +169,16 @@ EXPORT_API int connection_create(connection_h *connection)
        rv = _connection_libnet_init(*connection);
        if (rv == NET_ERR_ACCESS_DENIED) {
                CONNECTION_LOG(CONNECTION_ERROR, "Access denied"); //LCOV_EXCL_LINE
+               g_free(*connection);
+               *connection = NULL;
+
                CONN_UNLOCK; //LCOV_EXCL_LINE
                return CONNECTION_ERROR_PERMISSION_DENIED; //LCOV_EXCL_LINE
        } else if (rv != NET_ERR_NONE) {
                CONNECTION_LOG(CONNECTION_ERROR, "Failed to create connection[%d]", rv); //LCOV_EXCL_LINE
+               g_free(*connection);
+               *connection = NULL;
+
                CONN_UNLOCK; //LCOV_EXCL_LINE
                return CONNECTION_ERROR_OPERATION_FAILED; //LCOV_EXCL_LINE
        }