media: dvb-frontends/af9033.c: fix missing error codes
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 20 Jan 2021 09:09:05 +0000 (10:09 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 27 Jan 2021 07:38:27 +0000 (08:38 +0100)
Fixes two smatch warnings:

drivers/media/dvb-frontends/af9033.c:128 af9033_init() warn: missing error code 'ret'
drivers/media/dvb-frontends/af9033.c:855 af9033_read_snr() warn: missing error code 'ret'

Set error codes correctly.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/af9033.c

index 6a8d78b..785c49b 100644 (file)
@@ -125,6 +125,7 @@ static int af9033_init(struct dvb_frontend *fe)
        if (i == ARRAY_SIZE(clock_adc_lut)) {
                dev_err(&client->dev, "Couldn't find ADC config for clock %d\n",
                        dev->cfg.clock);
+               ret = -ENODEV;
                goto err;
        }
 
@@ -852,6 +853,7 @@ static int af9033_read_snr(struct dvb_frontend *fe, u16 *snr)
                                *snr = *snr * 0xffff / 32;
                                break;
                        default:
+                               ret = -EINVAL;
                                goto err;
                        }
                }