nvme: don't overwrite req->cmd_flags on sync cmd
authorMatias Bjørling <m@bjorling.me>
Fri, 5 Jun 2015 12:54:24 +0000 (14:54 +0200)
committerJens Axboe <axboe@fb.com>
Wed, 17 Jun 2015 15:36:57 +0000 (09:36 -0600)
In __nvme_submit_sync_cmd, the request direction is overwritten when
the REQ_FAILFAST_DRIVER flag is set.

Signed-off-by: Matias Bjørling <m@bjorling.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 75619bfa904d0 ("NVMe: End sync requests immediately on failure")
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/nvme-core.c

index 2072ae8..12d5b7b 100644 (file)
@@ -1010,7 +1010,7 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
                return PTR_ERR(req);
 
        req->cmd_type = REQ_TYPE_DRV_PRIV;
-       req->cmd_flags = REQ_FAILFAST_DRIVER;
+       req->cmd_flags |= REQ_FAILFAST_DRIVER;
        req->__data_len = 0;
        req->__sector = (sector_t) -1;
        req->bio = req->biotail = NULL;