phy: samsung: use of_device_get_match_data()
authorChunfeng Yun <chunfeng.yun@mediatek.com>
Wed, 9 Aug 2017 09:17:58 +0000 (17:17 +0800)
committerKishon Vijay Abraham I <kishon@ti.com>
Sun, 20 Aug 2017 08:29:52 +0000 (13:59 +0530)
reduce the boilerplate code to get the specific data

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/samsung/phy-exynos-dp-video.c
drivers/phy/samsung/phy-exynos5-usbdrd.c
drivers/phy/samsung/phy-samsung-usb2.c

index bb3279d..2dd6dd1 100644 (file)
@@ -16,6 +16,7 @@
 #include <linux/mfd/syscon.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
+#include <linux/of_device.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
@@ -78,7 +79,6 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
 {
        struct exynos_dp_video_phy *state;
        struct device *dev = &pdev->dev;
-       const struct of_device_id *match;
        struct phy_provider *phy_provider;
        struct phy *phy;
 
@@ -93,8 +93,7 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
                return PTR_ERR(state->regs);
        }
 
-       match = of_match_node(exynos_dp_video_phy_of_match, dev->of_node);
-       state->drvdata = match->data;
+       state->drvdata = of_device_get_match_data(dev);
 
        phy = devm_phy_create(dev, NULL, &exynos_dp_video_phy_ops);
        if (IS_ERR(phy)) {
index 7c41daa..22c68f5 100644 (file)
@@ -18,6 +18,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
+#include <linux/of_device.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/mutex.h>
@@ -662,7 +663,6 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
        struct exynos5_usbdrd_phy *phy_drd;
        struct phy_provider *phy_provider;
        struct resource *res;
-       const struct of_device_id *match;
        const struct exynos5_usbdrd_phy_drvdata *drv_data;
        struct regmap *reg_pmu;
        u32 pmu_offset;
@@ -681,9 +681,10 @@ static int exynos5_usbdrd_phy_probe(struct platform_device *pdev)
        if (IS_ERR(phy_drd->reg_phy))
                return PTR_ERR(phy_drd->reg_phy);
 
-       match = of_match_node(exynos5_usbdrd_phy_of_match, pdev->dev.of_node);
+       drv_data = of_device_get_match_data(dev);
+       if (!drv_data)
+               return -EINVAL;
 
-       drv_data = match->data;
        phy_drd->drv_data = drv_data;
 
        ret = exynos5_usbdrd_phy_clk_handle(phy_drd);
index 1d22d93..ea81886 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
+#include <linux/of_device.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/spinlock.h>
@@ -142,7 +143,6 @@ MODULE_DEVICE_TABLE(of, samsung_usb2_phy_of_match);
 
 static int samsung_usb2_phy_probe(struct platform_device *pdev)
 {
-       const struct of_device_id *match;
        const struct samsung_usb2_phy_config *cfg;
        struct device *dev = &pdev->dev;
        struct phy_provider *phy_provider;
@@ -155,12 +155,9 @@ static int samsung_usb2_phy_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       match = of_match_node(samsung_usb2_phy_of_match, pdev->dev.of_node);
-       if (!match) {
-               dev_err(dev, "of_match_node() failed\n");
+       cfg = of_device_get_match_data(dev);
+       if (!cfg)
                return -EINVAL;
-       }
-       cfg = match->data;
 
        drv = devm_kzalloc(dev, sizeof(struct samsung_usb2_phy_driver) +
                cfg->num_phys * sizeof(struct samsung_usb2_phy_instance),