net: ethernet: sun: use time_is_before_jiffies() instead of open coding it
authorWang Qing <wangqing@vivo.com>
Mon, 28 Feb 2022 03:13:15 +0000 (19:13 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Feb 2022 13:21:31 +0000 (13:21 +0000)
Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/cassini.c

index dba9f12..947a76a 100644 (file)
@@ -88,6 +88,7 @@
 #include <asm/io.h>
 #include <asm/byteorder.h>
 #include <linux/uaccess.h>
+#include <linux/jiffies.h>
 
 #define cas_page_map(x)      kmap_atomic((x))
 #define cas_page_unmap(x)    kunmap_atomic((x))
@@ -4063,8 +4064,8 @@ static void cas_link_timer(struct timer_list *t)
 
        if (link_transition_timeout != 0 &&
            cp->link_transition_jiffies_valid &&
-           ((jiffies - cp->link_transition_jiffies) >
-             (link_transition_timeout))) {
+           time_is_before_jiffies(cp->link_transition_jiffies +
+             link_transition_timeout)) {
                /* One-second counter so link-down workaround doesn't
                 * cause resets to occur so fast as to fool the switch
                 * into thinking the link is down.