Fix the prevent issue 22/91922/3 accepted/tizen/3.0/ivi/20161028.151433 accepted/tizen/3.0/mobile/20161028.143351 accepted/tizen/3.0/tv/20161028.143548 accepted/tizen/mobile/20161012.113848 accepted/tizen/tv/20161012.113902 submit/tizen_3.0/20161028.062323 submit/tizen_3.0/20161028.092423 submit/tizen_mobile/20161012.084335 submit/tizen_tv/20161012.084326
authorHyeKyoung Hwang <cookie@samsung.com>
Wed, 12 Oct 2016 07:36:56 +0000 (16:36 +0900)
committerHyeKyoung Hwang <cookie@samsung.com>
Wed, 12 Oct 2016 08:06:06 +0000 (17:06 +0900)
[ Issue ] Prevent WGID 67457 , 67458
[ Problme ] There have the null point issue
[ Soulution] Check the null point

Change-Id: I30d4ce54850c3006188e5bf3975f88fb67cf2566
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
provider/browser-provider-db.c

index 8cc477b3bb32645ef52563cfaa2a4e074fb0c746..abc76ce8e1eeb77d6d7f125a2957b209c1f3ee9f 100755 (executable)
@@ -1890,29 +1890,34 @@ int bp_db_backup(sqlite3 *handle, char *path)
        }
 
        errorcode = sqlite3_open(path, &backup_handle);
-       if (errorcode == SQLITE_OK) {
-               pbackup =
-                       sqlite3_backup_init(backup_handle, "main", handle, "main");
-               if (pbackup == NULL) {
-                       sqlite3_close(backup_handle);
-                       TRACE_ERROR("[INIT]");
-                       return -1;
-               }
-               do {
+       if(backup_handle) {
+           if (errorcode == SQLITE_OK) {
+                   pbackup =
+                               sqlite3_backup_init(backup_handle, "main", handle, "main");
+                   if (pbackup == NULL) {
+                           sqlite3_close(backup_handle);
+                           TRACE_ERROR("[INIT]");
+                           return -1;
+                   }
+                   do {
                        errorcode = sqlite3_backup_step(pbackup, -1);
                        TRACE_SECURE_INFO("progress (%d)",
                                (100 * (sqlite3_backup_pagecount(pbackup) -
                                sqlite3_backup_remaining(pbackup)) /
                                sqlite3_backup_pagecount(pbackup)));
-               } while (errorcode == SQLITE_OK); // more pages to be copied
-               sqlite3_backup_finish(pbackup);
-               if (errorcode == SQLITE_DONE) { // finished
+                   } while (errorcode == SQLITE_OK); // more pages to be copied
+                   sqlite3_backup_finish(pbackup);
+                   if (errorcode == SQLITE_DONE) { // finished
                        sqlite3_close(backup_handle);
                        return 0;
                }
+        }
+        TRACE_ERROR("[ERROR] [%s]", sqlite3_errmsg(backup_handle));
+        (void)sqlite3_close(backup_handle);
+       }
+       else {
+               TRACE_ERROR("bp_db_backup()  backup_handle is NULL");
        }
-       TRACE_ERROR("[ERROR] [%s]", sqlite3_errmsg(backup_handle));
-       (void)sqlite3_close(backup_handle);
        return -1;
 }
 
@@ -1932,7 +1937,8 @@ int bp_db_restore(sqlite3 *handle, char *path)
        }
 
        errorcode = sqlite3_open(path, &backup_handle);
-       if (errorcode == SQLITE_OK) {
+       if(backup_handle) {
+           if (errorcode == SQLITE_OK) {
                pbackup =
                        sqlite3_backup_init(handle, "main", backup_handle, "main");
                if (pbackup == NULL) {
@@ -1952,10 +1958,14 @@ int bp_db_restore(sqlite3 *handle, char *path)
                        sqlite3_close(backup_handle);
                        return 0;
                }
-       }
-       TRACE_ERROR("[ERROR] [%s]", sqlite3_errmsg(backup_handle));
-       (void)sqlite3_close(backup_handle);
-       return -1;
+          }
+          TRACE_ERROR("[ERROR] [%s]", sqlite3_errmsg(backup_handle));
+          (void)sqlite3_close(backup_handle);
+      }
+      else {
+       TRACE_ERROR("bp_db_restore()  backup_handle is NULL");
+      }
+       return -1;
 }
 
 char *bp_db_get_text_stmt(sqlite3_stmt* stmt, int index)