Coverty issue Email-service

Change-Id: Ief017f80669eabeaae2b50ff1ed5c001c0ac1104
Signed-off-by: kamaljeet <kamal.jc@samsung.com>

diff --git a/email-core/email-core-event.c b/email-core/email-core-event.c
index 67bf84e..caee045 100755 (executable)
--- a/email-core/email-core-event.c
+++ b/email-core/email-core-event.c
@@ -1737,6 +1737,7 @@ static void emcore_adjust_sync_mail_flag_event_priority()
                if ((err = emcore_update_sync_status_of_account(first->multi_user_name, first->account_id, SET_TYPE_MINUS, SYNC_STATUS_SYNCING)) != EMAIL_ERROR_NONE)
                        EM_DEBUG_EXCEPTION("emcore_update_sync_status_of_account failed [%d]", err);
        }
+       free(sync_flag_event_list);
        EM_DEBUG_FUNC_END();
 }
 

diff --git a/email-core/email-core-gmime.c b/email-core/email-core-gmime.c
index 7ec0c59..cb042e5 100755 (executable)
--- a/email-core/email-core-gmime.c
+++ b/email-core/email-core-gmime.c
@@ -4094,8 +4094,8 @@ INTERNAL_FUNC int emcore_gmime_fetch_imap_body_sections(MAILSTREAM *stream, int
 
                                        /* In some situation, total_encoded_len includes the length of dummy bytes.
                                         * So it might be greater than body_size */
-
-                                       download_progress = 100 * downloaded_size / download_total_size;
+                                       if (download_total_size != 0)
+                                               download_progress = 100 * downloaded_size / download_total_size;
 
                                        EM_DEBUG_LOG("DOWNLOADING STATUS NOTIFY:Total[%d]/[%d] = %d %% Completed",
                                                        downloaded_size, download_total_size, download_progress);

diff --git a/email-core/email-core-key-manager.c b/email-core/email-core-key-manager.c
index 6615dad..b8a3bc4 100644 (file)
--- a/email-core/email-core-key-manager.c
+++ b/email-core/email-core-key-manager.c
@@ -391,7 +391,7 @@ INTERNAL_FUNC int emcore_encryption_data_in_key_manager(const char *data_name, c
 
                EM_DEBUG_LOG("ckmc_param_list_set_buffer failed");
                err = EMAIL_ERROR_KEY_MANAGER_FAILURE;
-               return err;
+               goto FINISH_OFF;
 
        }
 

diff --git a/email-core/email-core-smtp.c b/email-core/email-core-smtp.c
index 8e41b93..f0b6418 100755 (executable)
--- a/email-core/email-core-smtp.c
+++ b/email-core/email-core-smtp.c
@@ -298,6 +298,7 @@ static int emcore_write_body(BODY *body, BODY *root_body, FILE *fp)
                        goto FINISH_OFF;
                }
 
+               memset( full_buf, '\0', (st_buf.st_size + 1) );
                byte_read = fread(full_buf, sizeof(char), st_buf.st_size, fp_html);
 
                if (byte_read <= 0) {
@@ -3223,6 +3224,7 @@ FINISH_OFF:
        EM_SAFE_FREE(encoded_file_name);
        EM_SAFE_FREE(result_file_name); /*prevent 26242*/
        EM_SAFE_FREE(base64_file_name);
+       EM_SAFE_FREE(glib_error);
        if (err_code != NULL)
                *err_code = error;
        EM_DEBUG_FUNC_END();

diff --git a/email-core/email-core-utils.c b/email-core/email-core-utils.c
index 01b57a0..cdd11c1 100755 (executable)
--- a/email-core/email-core-utils.c
+++ b/email-core/email-core-utils.c
@@ -2668,6 +2668,7 @@ int emcore_strip_mail_body_from_file(char *multi_user_name, emstorage_mail_tbl_t
                        goto FINISH_OFF;
                }
 
+               memset( buf, '\0', (st_buf.st_size + 1) );
                byte_read = fread(buf, sizeof(char), st_buf.st_size, fp_plain);
 
                if (byte_read <= 0) {
@@ -2833,6 +2834,7 @@ int emcore_get_preview_text_from_file(char *multi_user_name, const char *input_p
                        goto FINISH_OFF;
                }
 
+               memset( local_preview_text, '\0', local_preview_buffer_length );
                byte_read = fread(local_preview_text, sizeof(char), local_preview_buffer_length - 1, fp_plain);
 
                if (byte_read <= 0) { /*prevent 26249*/
@@ -2892,7 +2894,7 @@ FINISH_OFF:
        EM_SAFE_FREE(local_preview_text);
        EM_SAFE_FREE(encoding_type);
        EM_SAFE_FREE(prefix_path);
-
+       EM_SAFE_FREE(glib_error);
        if (fp_plain != NULL)
                fclose(fp_plain);
 
@@ -4113,6 +4115,7 @@ INTERNAL_FUNC int emcore_search_string_from_file(char *file_path, char *search_s
                goto FINISH_OFF;
        }
 
+       memset( buf, '\0', (file_size + 1) );
        if (fread(buf, sizeof(char), file_size, fp) != file_size) {
                EM_DEBUG_EXCEPTION("fread error [%d]", errno);
                error = EMAIL_ERROR_SYSTEM_FAILURE;
@@ -4207,6 +4210,7 @@ INTERNAL_FUNC int emcore_load_query_from_file(char *file_path, char ***query_arr
                goto FINISH_OFF;
        }
 
+       memset( buf, '\0', file_size + 1 );
        if (fread(buf, sizeof(char), file_size, fp) != file_size) {
                EM_DEBUG_EXCEPTION("Get the data from file : failed");
                error = EMAIL_ERROR_SYSTEM_FAILURE;

diff --git a/email-core/email-storage/email-storage.c b/email-core/email-storage/email-storage.c
index 5c2c152..fd1dc0c 100755 (executable)
--- a/email-core/email-storage/email-storage.c
+++ b/email-core/email-storage/email-storage.c
@@ -2968,6 +2968,8 @@ FINISH_OFF:
                if (ret == true) {
                        if (result_mail_list)
                                *result_mail_list = mail_list_item_from_tbl;
+                       else
+                               EM_SAFE_FREE(mail_list_item_from_tbl);
                        *result_count = count;
                } else
                        EM_SAFE_FREE(mail_list_item_from_tbl);
@@ -12040,6 +12042,7 @@ INTERNAL_FUNC int emstorage_add_content_type(char *file_path, char *char_set, in
                goto FINISH_OFF;
        }
 
+       memset( buf, '\0', buf_size+1 );
        if ((nread = fread(buf, 1, buf_size, fp_src)) > 0) {
                if (nread > 0 && nread <= buf_size) {
                        EM_DEBUG_LOG(">>>> Nread Value [ %d ] ", nread);