bus: fsl-mc: fsl-mc-allocator: Initialize mc_bus_dev before use
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 5 Jun 2023 11:20:24 +0000 (13:20 +0200)
committerLi Yang <leoyang.li@nxp.com>
Thu, 8 Jun 2023 22:56:26 +0000 (17:56 -0500)
Fixes a clang compiler warning:

>> drivers/bus/fsl-mc/fsl-mc-allocator.c:108:12: warning: variable 'mc_bus_dev' is uninitialized when used here [-Wuninitialized]
                   dev_err(&mc_bus_dev->dev, "resource mismatch\n");

Fixes: b3134039c5b3 ("bus: fsl-mc: fsl-mc-allocator: Improve error reporting")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202306021936.OktTcMAT-lkp@intel.com/
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
drivers/bus/fsl-mc/fsl-mc-allocator.c

index 0ad6809..991273f 100644 (file)
@@ -103,14 +103,15 @@ static int __must_check fsl_mc_resource_pool_remove_device(struct fsl_mc_device
        struct fsl_mc_resource *resource;
        int error = -EINVAL;
 
+       mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);
+       mc_bus = to_fsl_mc_bus(mc_bus_dev);
+
        resource = mc_dev->resource;
        if (!resource || resource->data != mc_dev) {
                dev_err(&mc_bus_dev->dev, "resource mismatch\n");
                goto out;
        }
 
-       mc_bus_dev = to_fsl_mc_device(mc_dev->dev.parent);
-       mc_bus = to_fsl_mc_bus(mc_bus_dev);
        res_pool = resource->parent_pool;
        if (res_pool != &mc_bus->resource_pools[resource->type]) {
                dev_err(&mc_bus_dev->dev, "pool mismatch\n");