d3d11converter: Remove convert() method
authorSeungha Yang <seungha@centricular.com>
Mon, 4 Jul 2022 13:27:34 +0000 (22:27 +0900)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 4 Jul 2022 18:46:51 +0000 (18:46 +0000)
Expose only single convert_buffer() method. It's safer approach than
passing arbitrary list of SRV/RTV pointers.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2713>

subprojects/gst-plugins-bad/sys/d3d11/gstd3d11converter.cpp
subprojects/gst-plugins-bad/sys/d3d11/gstd3d11converter.h

index 91aa44c..01a1ec0 100644 (file)
@@ -3128,36 +3128,6 @@ out:
   return ret;
 }
 
-gboolean
-gst_d3d11_converter_convert (GstD3D11Converter * converter,
-    ID3D11ShaderResourceView * srv[GST_VIDEO_MAX_PLANES],
-    ID3D11RenderTargetView * rtv[GST_VIDEO_MAX_PLANES])
-{
-  gboolean ret;
-
-  g_return_val_if_fail (GST_IS_D3D11_CONVERTER (converter), FALSE);
-  g_return_val_if_fail (srv != nullptr, FALSE);
-  g_return_val_if_fail (rtv != nullptr, FALSE);
-
-  gst_d3d11_device_lock (converter->device);
-  ret = gst_d3d11_converter_convert_internal (converter, srv, rtv);
-  gst_d3d11_device_unlock (converter->device);
-
-  return ret;
-}
-
-gboolean
-gst_d3d11_converter_convert_unlocked (GstD3D11Converter * converter,
-    ID3D11ShaderResourceView * srv[GST_VIDEO_MAX_PLANES],
-    ID3D11RenderTargetView * rtv[GST_VIDEO_MAX_PLANES])
-{
-  g_return_val_if_fail (GST_IS_D3D11_CONVERTER (converter), FALSE);
-  g_return_val_if_fail (srv != nullptr, FALSE);
-  g_return_val_if_fail (rtv != nullptr, FALSE);
-
-  return gst_d3d11_converter_convert_internal (converter, srv, rtv);
-}
-
 static gboolean
 gst_d3d11_converter_check_bind_flags_for_piv (guint bind_flags)
 {
index 24242af..213e792 100644 (file)
@@ -70,14 +70,6 @@ GstD3D11Converter * gst_d3d11_converter_new  (GstD3D11Device * device,
                                               const GstVideoInfo * out_info,
                                               GstD3D11ConverterMethod * method);
 
-gboolean            gst_d3d11_converter_convert (GstD3D11Converter * converter,
-                                                 ID3D11ShaderResourceView *srv[GST_VIDEO_MAX_PLANES],
-                                                 ID3D11RenderTargetView *rtv[GST_VIDEO_MAX_PLANES]);
-
-gboolean            gst_d3d11_converter_convert_unlocked (GstD3D11Converter * converter,
-                                                          ID3D11ShaderResourceView *srv[GST_VIDEO_MAX_PLANES],
-                                                          ID3D11RenderTargetView *rtv[GST_VIDEO_MAX_PLANES]);
-
 gboolean            gst_d3d11_converter_convert_buffer (GstD3D11Converter * converter,
                                                         GstBuffer * in_buf,
                                                         GstBuffer * out_buf);