accel/habanalabs: minimize error prints when mem map fails
authorMoti Haimovski <mhaimovski@habana.ai>
Wed, 25 Jan 2023 18:16:19 +0000 (20:16 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Wed, 15 Mar 2023 11:29:12 +0000 (13:29 +0200)
This commit minimizes the "chain of errors" displayed when memory
mapping fails.

Signed-off-by: Moti Haimovski <mhaimovski@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
drivers/accel/habanalabs/common/memory.c

index 7fd8e8f..be4fa97 100644 (file)
@@ -235,10 +235,8 @@ static int dma_map_host_va(struct hl_device *hdev, u64 addr, u64 size,
        }
 
        rc = hl_pin_host_memory(hdev, addr, size, userptr);
-       if (rc) {
-               dev_err(hdev->dev, "Failed to pin host memory\n");
+       if (rc)
                goto pin_err;
-       }
 
        userptr->dma_mapped = true;
        userptr->dir = DMA_BIDIRECTIONAL;
@@ -1097,10 +1095,8 @@ static int map_device_va(struct hl_ctx *ctx, struct hl_mem_in *args, u64 *device
                        huge_page_size = hdev->asic_prop.pmmu_huge.page_size;
 
                rc = dma_map_host_va(hdev, addr, size, &userptr);
-               if (rc) {
-                       dev_err(hdev->dev, "failed to get userptr from va\n");
+               if (rc)
                        return rc;
-               }
 
                rc = init_phys_pg_pack_from_userptr(ctx, userptr,
                                &phys_pg_pack, false);