crypto: hisilicon/hpre - the macro 'HPRE_ADDR' expands
authorHui Tang <tanghui20@huawei.com>
Wed, 12 May 2021 06:27:04 +0000 (14:27 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 21 May 2021 08:17:30 +0000 (16:17 +0800)
The macro 'HPRE_ADDR' is unnecessary, so expanding it.

Signed-off-by: Hui Tang <tanghui20@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/hpre/hpre_main.c

index 046bc96..c914e00 100644 (file)
@@ -69,7 +69,6 @@
 #define HPRE_DBGFS_VAL_MAX_LEN         20
 #define HPRE_PCI_DEVICE_ID             0xa258
 #define HPRE_PCI_VF_DEVICE_ID          0xa259
-#define HPRE_ADDR(qm, offset)          ((qm)->io_base + (offset))
 #define HPRE_QM_USR_CFG_MASK           0xfffffffe
 #define HPRE_QM_AXI_CFG_MASK           0xffff
 #define HPRE_QM_VFG_AX_MASK            0xff
@@ -302,10 +301,10 @@ static int hpre_set_cluster(struct hisi_qm *qm)
 
                /* clusters initiating */
                writel(cluster_core_mask,
-                      HPRE_ADDR(qm, offset + HPRE_CORE_ENB));
-               writel(0x1, HPRE_ADDR(qm, offset + HPRE_CORE_INI_CFG));
-               ret = readl_relaxed_poll_timeout(HPRE_ADDR(qm, offset +
-                                       HPRE_CORE_INI_STATUS), val,
+                      qm->io_base + offset + HPRE_CORE_ENB);
+               writel(0x1, qm->io_base + offset + HPRE_CORE_INI_CFG);
+               ret = readl_relaxed_poll_timeout(qm->io_base + offset +
+                                       HPRE_CORE_INI_STATUS, val,
                                        ((val & cluster_core_mask) ==
                                        cluster_core_mask),
                                        HPRE_REG_RD_INTVRL_US,
@@ -329,11 +328,11 @@ static void disable_flr_of_bme(struct hisi_qm *qm)
 {
        u32 val;
 
-       val = readl(HPRE_ADDR(qm, QM_PEH_AXUSER_CFG));
+       val = readl(qm->io_base + QM_PEH_AXUSER_CFG);
        val &= ~(HPRE_QM_BME_FLR | HPRE_QM_SRIOV_FLR);
        val |= HPRE_QM_PM_FLR;
-       writel(val, HPRE_ADDR(qm, QM_PEH_AXUSER_CFG));
-       writel(PEH_AXUSER_CFG_ENABLE, HPRE_ADDR(qm, QM_PEH_AXUSER_CFG_ENABLE));
+       writel(val, qm->io_base + QM_PEH_AXUSER_CFG);
+       writel(PEH_AXUSER_CFG_ENABLE, qm->io_base + QM_PEH_AXUSER_CFG_ENABLE);
 }
 
 static int hpre_set_user_domain_and_cache(struct hisi_qm *qm)
@@ -342,33 +341,33 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm *qm)
        u32 val;
        int ret;
 
-       writel(HPRE_QM_USR_CFG_MASK, HPRE_ADDR(qm, QM_ARUSER_M_CFG_ENABLE));
-       writel(HPRE_QM_USR_CFG_MASK, HPRE_ADDR(qm, QM_AWUSER_M_CFG_ENABLE));
-       writel_relaxed(HPRE_QM_AXI_CFG_MASK, HPRE_ADDR(qm, QM_AXI_M_CFG));
+       writel(HPRE_QM_USR_CFG_MASK, qm->io_base + QM_ARUSER_M_CFG_ENABLE);
+       writel(HPRE_QM_USR_CFG_MASK, qm->io_base + QM_AWUSER_M_CFG_ENABLE);
+       writel_relaxed(HPRE_QM_AXI_CFG_MASK, qm->io_base + QM_AXI_M_CFG);
 
        /* HPRE need more time, we close this interrupt */
-       val = readl_relaxed(HPRE_ADDR(qm, HPRE_QM_ABNML_INT_MASK));
+       val = readl_relaxed(qm->io_base + HPRE_QM_ABNML_INT_MASK);
        val |= BIT(HPRE_TIMEOUT_ABNML_BIT);
-       writel_relaxed(val, HPRE_ADDR(qm, HPRE_QM_ABNML_INT_MASK));
+       writel_relaxed(val, qm->io_base + HPRE_QM_ABNML_INT_MASK);
 
        if (qm->ver >= QM_HW_V3)
                writel(HPRE_RSA_ENB | HPRE_ECC_ENB,
-                       HPRE_ADDR(qm, HPRE_TYPES_ENB));
+                       qm->io_base + HPRE_TYPES_ENB);
        else
-               writel(HPRE_RSA_ENB, HPRE_ADDR(qm, HPRE_TYPES_ENB));
-
-       writel(HPRE_QM_VFG_AX_MASK, HPRE_ADDR(qm, HPRE_VFG_AXCACHE));
-       writel(0x0, HPRE_ADDR(qm, HPRE_BD_ENDIAN));
-       writel(0x0, HPRE_ADDR(qm, HPRE_INT_MASK));
-       writel(0x0, HPRE_ADDR(qm, HPRE_POISON_BYPASS));
-       writel(0x0, HPRE_ADDR(qm, HPRE_COMM_CNT_CLR_CE));
-       writel(0x0, HPRE_ADDR(qm, HPRE_ECC_BYPASS));
-
-       writel(HPRE_BD_USR_MASK, HPRE_ADDR(qm, HPRE_BD_ARUSR_CFG));
-       writel(HPRE_BD_USR_MASK, HPRE_ADDR(qm, HPRE_BD_AWUSR_CFG));
-       writel(0x1, HPRE_ADDR(qm, HPRE_RDCHN_INI_CFG));
-       ret = readl_relaxed_poll_timeout(HPRE_ADDR(qm, HPRE_RDCHN_INI_ST), val,
-                                        val & BIT(0),
+               writel(HPRE_RSA_ENB, qm->io_base + HPRE_TYPES_ENB);
+
+       writel(HPRE_QM_VFG_AX_MASK, qm->io_base + HPRE_VFG_AXCACHE);
+       writel(0x0, qm->io_base + HPRE_BD_ENDIAN);
+       writel(0x0, qm->io_base + HPRE_INT_MASK);
+       writel(0x0, qm->io_base + HPRE_POISON_BYPASS);
+       writel(0x0, qm->io_base + HPRE_COMM_CNT_CLR_CE);
+       writel(0x0, qm->io_base + HPRE_ECC_BYPASS);
+
+       writel(HPRE_BD_USR_MASK, qm->io_base + HPRE_BD_ARUSR_CFG);
+       writel(HPRE_BD_USR_MASK, qm->io_base + HPRE_BD_AWUSR_CFG);
+       writel(0x1, qm->io_base + HPRE_RDCHN_INI_CFG);
+       ret = readl_relaxed_poll_timeout(qm->io_base + HPRE_RDCHN_INI_ST, val,
+                       val & BIT(0),
                        HPRE_REG_RD_INTVRL_US,
                        HPRE_REG_RD_TMOUT_US);
        if (ret) {
@@ -802,9 +801,9 @@ static void hpre_open_axi_master_ooo(struct hisi_qm *qm)
 
        value = readl(qm->io_base + HPRE_AM_OOO_SHUTDOWN_ENB);
        writel(value & ~HPRE_AM_OOO_SHUTDOWN_ENABLE,
-              HPRE_ADDR(qm, HPRE_AM_OOO_SHUTDOWN_ENB));
+              qm->io_base + HPRE_AM_OOO_SHUTDOWN_ENB);
        writel(value | HPRE_AM_OOO_SHUTDOWN_ENABLE,
-              HPRE_ADDR(qm, HPRE_AM_OOO_SHUTDOWN_ENB));
+              qm->io_base + HPRE_AM_OOO_SHUTDOWN_ENB);
 }
 
 static void hpre_err_info_init(struct hisi_qm *qm)