PM / devfreq: mtk-cci: Handle sram regulator probe deferral
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Wed, 13 Jul 2022 11:15:11 +0000 (13:15 +0200)
committerChanwoo Choi <cw00.choi@samsung.com>
Sun, 25 Sep 2022 18:59:12 +0000 (03:59 +0900)
If the regulator_get_optional() call for the SRAM regulator returns
a probe deferral, we must bail out and retry probing later: failing
to do this will produce unstabilities on platforms requiring the
handling for this regulator.

Fixes: b615b00c42da ("PM / devfreq: mediatek: Introduce MediaTek CCI devfreq driver")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/devfreq/mtk-cci-devfreq.c

index 71abb3f..e5458ad 100644 (file)
@@ -291,9 +291,13 @@ static int mtk_ccifreq_probe(struct platform_device *pdev)
        }
 
        drv->sram_reg = devm_regulator_get_optional(dev, "sram");
-       if (IS_ERR(drv->sram_reg))
+       if (IS_ERR(drv->sram_reg)) {
+               ret = PTR_ERR(drv->sram_reg);
+               if (ret == -EPROBE_DEFER)
+                       goto out_free_resources;
+
                drv->sram_reg = NULL;
-       else {
+       else {
                ret = regulator_enable(drv->sram_reg);
                if (ret) {
                        dev_err(dev, "failed to enable sram regulator\n");