r600/sfn: Clean up FS member initialization
authorGert Wollny <gert.wollny@collabora.com>
Mon, 19 Jun 2023 06:55:10 +0000 (08:55 +0200)
committerMarge Bot <emma+marge@anholt.net>
Mon, 19 Jun 2023 22:40:44 +0000 (22:40 +0000)
All members that are initialized with predefined values should
be initialized with the declaration.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23717>

src/gallium/drivers/r600/sfn/sfn_shader_fs.cpp
src/gallium/drivers/r600/sfn/sfn_shader_fs.h

index 95f886e..4345015 100644 (file)
@@ -42,10 +42,6 @@ FragmentShader::FragmentShader(const r600_shader_key& key):
     Shader("FS", key.ps.first_atomic_counter),
     m_dual_source_blend(key.ps.dual_source_blend),
     m_max_color_exports(MAX2(key.ps.nr_cbufs, 1)),
-    m_export_highest(0),
-    m_num_color_exports(0),
-    m_color_export_mask(0),
-    m_last_pixel_export(nullptr),
     m_pos_input(127, false),
     m_fs_write_all(false),
     m_apply_sample_mask(key.ps.apply_sample_id_mask),
index faf62fc..cc01653 100644 (file)
@@ -70,18 +70,18 @@ private:
 
    void do_print_properties(std::ostream& os) const override;
 
-   bool m_dual_source_blend;
-   unsigned m_max_color_exports;
-   unsigned m_export_highest;
-   unsigned m_num_color_exports;
-   unsigned m_color_export_mask;
-   ExportInstr *m_last_pixel_export;
+   bool m_dual_source_blend{false};
+   unsigned m_max_color_exports{0};
+   unsigned m_export_highest{0};
+   unsigned m_num_color_exports{0};
+   unsigned m_color_export_mask{0};
    unsigned m_color_export_written_mask{0};
+   ExportInstr *m_last_pixel_export{nullptr};
 
    std::bitset<s_max_interpolators> m_interpolators_used;
    RegisterVec4 m_pos_input;
    Register *m_face_input{nullptr};
-   bool m_fs_write_all;
+   bool m_fs_write_all{false};
    bool m_uses_discard{false};
    bool m_gs_prim_id_input{false};
    int m_ps_prim_id_input{0};