mlx4: remove unnecessary pci_set_drvdata()
authorZhu Yanjun <yanjun.zhu@oracle.com>
Tue, 15 Aug 2017 06:33:05 +0000 (02:33 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Aug 2017 23:46:48 +0000 (16:46 -0700)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not necessary to manually clear the
device driver data to NULL.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/main.c

index 09b9bc1..df9b0ef 100644 (file)
@@ -3782,7 +3782,6 @@ err_release_regions:
 
 err_disable_pdev:
        mlx4_pci_disable_device(&priv->dev);
-       pci_set_drvdata(pdev, NULL);
        return err;
 }
 
@@ -3997,7 +3996,6 @@ static void mlx4_remove_one(struct pci_dev *pdev)
        devlink_unregister(devlink);
        kfree(dev->persist);
        devlink_free(devlink);
-       pci_set_drvdata(pdev, NULL);
 }
 
 static int restore_current_port_types(struct mlx4_dev *dev,