ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 22 May 2021 09:50:54 +0000 (11:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:56:21 +0000 (16:56 +0200)
[ Upstream commit 515bda1d1e51c64edf2a384a58801f85a80a3f2d ]

All error paths but this one 'goto err' in order to release some
resources.
Fix this.

Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/ath/ath11k/core.c

index a68fe3a..28de2c7 100644 (file)
@@ -329,7 +329,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab,
                if (len < ALIGN(ie_len, 4)) {
                        ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n",
                                   ie_id, ie_len, len);
-                       return -EINVAL;
+                       ret = -EINVAL;
+                       goto err;
                }
 
                switch (ie_id) {