mm/percpu: Update the code comment when creating new chunk
authorBaoquan He <bhe@redhat.com>
Mon, 24 Oct 2022 08:14:30 +0000 (16:14 +0800)
committerDennis Zhou <dennis@kernel.org>
Tue, 8 Nov 2022 06:59:06 +0000 (22:59 -0800)
The lock pcpu_alloc_mutex taking code has been moved to the beginning of
pcpu_allo() if it's non atomic allocation. So the code comment above
above pcpu_create_chunk() callsite need be updated.

Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
mm/percpu.c

index 841bb93aaae6862b510487ce3aadbbb93dda1260..68d5ba61c93548f8081c4d05cf1fa8e6f4be5bd1 100644 (file)
@@ -1817,16 +1817,12 @@ restart:
 
        spin_unlock_irqrestore(&pcpu_lock, flags);
 
-       /*
-        * No space left.  Create a new chunk.  We don't want multiple
-        * tasks to create chunks simultaneously.  Serialize and create iff
-        * there's still no empty chunk after grabbing the mutex.
-        */
        if (is_atomic) {
                err = "atomic alloc failed, no space left";
                goto fail;
        }
 
+       /* No space left.  Create a new chunk. */
        if (list_empty(&pcpu_chunk_lists[pcpu_free_slot])) {
                chunk = pcpu_create_chunk(pcpu_gfp);
                if (!chunk) {