spi: omap2-mcspi: Fix probe so driver works again
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Sep 2022 07:24:51 +0000 (10:24 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 21 Sep 2022 09:28:20 +0000 (10:28 +0100)
This condition was accidentally changed from "if (status < 0)" to
"if (status)".  The platform_get_irq() function returns non-zero
positive values on success so, unfortunately, the driver could not be
used.  Change the condition back to how it was.

Fixes: f4ca8c88c2c7 ("spi: omap2-mcspi: Switch to use dev_err_probe() helper")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/Yyq8Q/kd301wVzg8@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-omap2-mcspi.c

index 80e79f3..6ba9b0d 100644 (file)
@@ -1509,7 +1509,7 @@ static int omap2_mcspi_probe(struct platform_device *pdev)
        }
 
        status = platform_get_irq(pdev, 0);
-       if (status) {
+       if (status < 0) {
                dev_err_probe(&pdev->dev, status, "no irq resource found\n");
                goto free_master;
        }