scsi: ufs: Print real incorrect request response code
authorStanley Chu <stanley.chu@mediatek.com>
Mon, 15 Apr 2019 12:23:38 +0000 (20:23 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Apr 2019 02:17:19 +0000 (22:17 -0400)
If UFS device responds an unknown request response code, we can not know
what it was via logs because the code is replaced by "DID_ERROR << 16"
before log printing.

Fix this to provide precise request response code information for easier
issue breakdown.

Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index b9a3d67..8c1c551 100644 (file)
@@ -4704,10 +4704,10 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
                                "Reject UPIU not fully implemented\n");
                        break;
                default:
-                       result = DID_ERROR << 16;
                        dev_err(hba->dev,
                                "Unexpected request response code = %x\n",
                                result);
+                       result = DID_ERROR << 16;
                        break;
                }
                break;