RDMA/ocrdma: Simplify code in 'ocrdma_search_mmap()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 25 Nov 2021 19:34:11 +0000 (20:34 +0100)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 29 Nov 2021 18:33:55 +0000 (14:33 -0400)
'pd_bitmap' does not need to be const. Without it, it is possible to use
this variable when calling '__set_bit()'. This is less verbose and more
logical.

Link: https://lore.kernel.org/r/ec5cab9611ba062adea4cf8c98a63406ed510a71.1637868728.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c

index 72629e7..bfa7aad 100644 (file)
@@ -247,13 +247,13 @@ static bool ocrdma_search_mmap(struct ocrdma_ucontext *uctx, u64 phy_addr,
 static u16 _ocrdma_pd_mgr_get_bitmap(struct ocrdma_dev *dev, bool dpp_pool)
 {
        u16 pd_bitmap_idx = 0;
-       const unsigned long *pd_bitmap;
+       unsigned long *pd_bitmap;
 
        if (dpp_pool) {
                pd_bitmap = dev->pd_mgr->pd_dpp_bitmap;
                pd_bitmap_idx = find_first_zero_bit(pd_bitmap,
                                                    dev->pd_mgr->max_dpp_pd);
-               __set_bit(pd_bitmap_idx, dev->pd_mgr->pd_dpp_bitmap);
+               __set_bit(pd_bitmap_idx, pd_bitmap);
                dev->pd_mgr->pd_dpp_count++;
                if (dev->pd_mgr->pd_dpp_count > dev->pd_mgr->pd_dpp_thrsh)
                        dev->pd_mgr->pd_dpp_thrsh = dev->pd_mgr->pd_dpp_count;
@@ -261,7 +261,7 @@ static u16 _ocrdma_pd_mgr_get_bitmap(struct ocrdma_dev *dev, bool dpp_pool)
                pd_bitmap = dev->pd_mgr->pd_norm_bitmap;
                pd_bitmap_idx = find_first_zero_bit(pd_bitmap,
                                                    dev->pd_mgr->max_normal_pd);
-               __set_bit(pd_bitmap_idx, dev->pd_mgr->pd_norm_bitmap);
+               __set_bit(pd_bitmap_idx, pd_bitmap);
                dev->pd_mgr->pd_norm_count++;
                if (dev->pd_mgr->pd_norm_count > dev->pd_mgr->pd_norm_thrsh)
                        dev->pd_mgr->pd_norm_thrsh = dev->pd_mgr->pd_norm_count;