iommufd: Fix uninitialized rc in iommufd_access_rw()
authorNicolin Chen <nicolinc@nvidia.com>
Thu, 27 Feb 2025 20:07:29 +0000 (12:07 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:30 +0000 (10:45 +0200)
commit a05df03a88bc1088be8e9d958f208d6484691e43 upstream.

Reported by smatch:
drivers/iommu/iommufd/device.c:1392 iommufd_access_rw() error: uninitialized symbol 'rc'.

Fixes: 8d40205f6093 ("iommufd: Add kAPI toward external drivers for kernel access")
Link: https://patch.msgid.link/r/20250227200729.85030-1-nicolinc@nvidia.com
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202502271339.a2nWr9UA-lkp@intel.com/
[nicolinc: can't find an original report but only in "old smatch warnings"]
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/iommufd/device.c

index ce78c3671539c77d27059d3aa11c7367f493eeff..cf76a0eeeded51044ef74cd331c7cab8afd89b98 100644 (file)
@@ -1076,7 +1076,7 @@ int iommufd_access_rw(struct iommufd_access *access, unsigned long iova,
        struct io_pagetable *iopt;
        struct iopt_area *area;
        unsigned long last_iova;
-       int rc;
+       int rc = -EINVAL;
 
        if (!length)
                return -EINVAL;