backlight: pwm_bl: Remove unneeded checks for valid GPIOs
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 23 May 2023 15:40:41 +0000 (17:40 +0200)
committerLee Jones <lee@kernel.org>
Thu, 25 May 2023 11:27:47 +0000 (12:27 +0100)
All of gpiod_set_value_cansleep() and gpiod_direction_output() handle
NULL GPIO pointers just fine, so there is no need to check for that in
the caller.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/00be8237e0e2bc9b179177b5490f175d657261a2.1684856337.git.geert+renesas@glider.be
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/video/backlight/pwm_bl.c

index fce4122..a51fbab 100644 (file)
@@ -54,8 +54,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb)
        if (pb->post_pwm_on_delay)
                msleep(pb->post_pwm_on_delay);
 
-       if (pb->enable_gpio)
-               gpiod_set_value_cansleep(pb->enable_gpio, 1);
+       gpiod_set_value_cansleep(pb->enable_gpio, 1);
 
        pb->enabled = true;
 }
@@ -65,8 +64,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb)
        if (!pb->enabled)
                return;
 
-       if (pb->enable_gpio)
-               gpiod_set_value_cansleep(pb->enable_gpio, 0);
+       gpiod_set_value_cansleep(pb->enable_gpio, 0);
 
        if (pb->pwm_off_delay)
                msleep(pb->pwm_off_delay);
@@ -429,8 +427,7 @@ static int pwm_backlight_initial_power_state(const struct pwm_bl_data *pb)
         * Synchronize the enable_gpio with the observed state of the
         * hardware.
         */
-       if (pb->enable_gpio)
-               gpiod_direction_output(pb->enable_gpio, active);
+       gpiod_direction_output(pb->enable_gpio, active);
 
        /*
         * Do not change pb->enabled here! pb->enabled essentially