Fix some parameter name inconsistencies
authorMatthias Maennich <maennich@google.com>
Wed, 29 Jan 2020 14:54:10 +0000 (14:54 +0000)
committerMatthias Maennich <maennich@google.com>
Mon, 3 Feb 2020 14:39:18 +0000 (14:39 +0000)
Clang-tidy flags those name inconsistencies and they are trivial to fix,
hence just do it. No functional change.

* src/abg-comparison-priv.h
(corpus_diff::priv::count_unreachable_types): use consistent
parameter naming.
* tools/abidiff.cc(main): Likewise.

Reviewed-by: Dodji Seketeli <dodji@seketeli.org>
Signed-off-by: Matthias Maennich <maennich@google.com>
src/abg-comparison-priv.h
tools/abidiff.cc

index 14799468475dc2a20e928ae44f9972c315316dc8..ff50c793c88e88b722993581b052b4e36dfca452 100644 (file)
@@ -1097,12 +1097,12 @@ struct corpus_diff::priv
   void count_leaf_type_changes(size_t &num_type_changes,
                               size_t &num_type_changes_filtered);
 
-  void count_unreachable_types(size_t &num_added_unreachable_types,
-                              size_t &num_removed_unreachable_types,
-                              size_t &num_changed_unreachable_types,
-                              size_t &num_filtered_added_unreachable_types,
-                              size_t &num_filtered_removed_unreachable_types,
-                              size_t &num_filtered_changed_unreachable_types);
+  void count_unreachable_types(size_t &num_added,
+                              size_t &num_removed,
+                              size_t &num_changed,
+                              size_t &num_filtered_added,
+                              size_t &num_filtered_removed,
+                              size_t &num_filtered_changed);
 
   const vector<diff_sptr>&
   changed_unreachable_types_sorted() const;
index 32f793e8a5147e9425554ea3ca54408fc646c915..824a30b0859b1a4ccd03924b950b541cf757005c 100644 (file)
@@ -1083,7 +1083,7 @@ main(int argc, char* argv[])
            abigail::dwarf_reader::read_context_sptr ctxt =
              abigail::dwarf_reader::create_read_context
              (opts.file1, opts.prepared_di_root_paths1,
-              env.get(), /*readalltypes=*/opts.show_all_types,
+              env.get(), /*read_all_types=*/opts.show_all_types,
               opts.linux_kernel_mode);
            assert(ctxt);
 
@@ -1159,7 +1159,7 @@ main(int argc, char* argv[])
            abigail::dwarf_reader::read_context_sptr ctxt =
              abigail::dwarf_reader::create_read_context
              (opts.file2, opts.prepared_di_root_paths2,
-              env.get(), /*readalltypes=*/opts.show_all_types,
+              env.get(), /*read_all_types=*/opts.show_all_types,
               opts.linux_kernel_mode);
            assert(ctxt);
            abigail::dwarf_reader::set_show_stats(*ctxt, opts.show_stats);