fs/ntfs3: Harden against integer overflows
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 12 Sep 2022 15:08:51 +0000 (18:08 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Fri, 30 Sep 2022 14:39:53 +0000 (17:39 +0300)
Smatch complains that the "add_bytes" is not to be trusted.  Use
size_add() to prevent an integer overflow.

Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/xattr.c

index 6ae1f56..2b4019e 100644 (file)
@@ -107,7 +107,7 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
                return -EFBIG;
 
        /* Allocate memory for packed Ea. */
-       ea_p = kmalloc(size + add_bytes, GFP_NOFS);
+       ea_p = kmalloc(size_add(size, add_bytes), GFP_NOFS);
        if (!ea_p)
                return -ENOMEM;