projects
/
platform
/
upstream
/
flac.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6c2040d
)
Fix buffer overflow by replacing strcpy with memcpy.
author
Erik de Castro Lopo
<erikd@mega-nerd.com>
Thu, 5 Apr 2012 11:02:40 +0000
(21:02 +1000)
committer
Erik de Castro Lopo
<erikd@mega-nerd.com>
Thu, 5 Apr 2012 11:02:40 +0000
(21:02 +1000)
Thanks to Cristian RodrÃguez <crrodriguez@opensuse.org> for the
report.
src/metaflac/options.c
patch
|
blob
|
history
diff --git
a/src/metaflac/options.c
b/src/metaflac/options.c
index
eb3498d
..
f242618
100644
(file)
--- a/
src/metaflac/options.c
+++ b/
src/metaflac/options.c
@@
-1041,7
+1041,7
@@
FLAC__bool parse_block_type(const char *in, Argument_BlockType *out)
out->entries[entry].filter_application_by_id = (0 != r);
if(0 != r) {
if(strlen(r) == 4) {
-
strcpy(out->entries[entry].application_id, r
);
+
memcpy(out->entries[entry].application_id, r, 4
);
}
else if(strlen(r) == 10 && strncmp(r, "0x", 2) == 0 && strspn(r+2, "0123456789ABCDEFabcdef") == 8) {
FLAC__uint32 x = strtoul(r+2, 0, 16);