mt76: connac: remove PHY_MODE_AX_6G configuration in mt76_connac_get_phy_mode
authorLorenzo Bianconi <lorenzo@kernel.org>
Thu, 18 Nov 2021 15:21:43 +0000 (16:21 +0100)
committerFelix Fietkau <nbd@nbd.name>
Sun, 19 Dec 2021 14:23:59 +0000 (15:23 +0100)
Get rid of PHY_MODE_AX_6G configuration in mt76_connac_get_phy_mode
routine since mode is an u8 and PHY_MODE_AX_6G is set in phymode_ext
field in mt76_connac_bss_basic_tlv.

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.c
drivers/net/wireless/mediatek/mt76/mt76_connac_mcu.h

index bcb5966..eba827f 100644 (file)
@@ -1190,12 +1190,8 @@ mt76_connac_get_phy_mode(struct mt76_phy *phy, struct ieee80211_vif *vif,
                if (vht_cap->vht_supported)
                        mode |= PHY_MODE_AC;
 
-               if (he_cap && he_cap->has_he) {
-                       if (band == NL80211_BAND_6GHZ)
-                               mode |= PHY_MODE_AX_6G;
-                       else
-                               mode |= PHY_MODE_AX_5G;
-               }
+               if (he_cap && he_cap->has_he && band == NL80211_BAND_5GHZ)
+                       mode |= PHY_MODE_AX_5G;
        }
 
        return mode;
@@ -1318,7 +1314,7 @@ int mt76_connac_mcu_uni_add_bss(struct mt76_phy *phy,
        idx = mvif->omac_idx > EXT_BSSID_START ? HW_BSSID_0 : mvif->omac_idx;
        basic_req.basic.hw_bss_idx = idx;
        if (band == NL80211_BAND_6GHZ)
-               basic_req.basic.phymode_ext = BIT(0);
+               basic_req.basic.phymode_ext = PHY_MODE_AX_6G;
 
        basic_phy = mt76_connac_get_phy_mode_v2(phy, vif, band, NULL);
        basic_req.basic.nonht_basic_phy = cpu_to_le16(basic_phy);
index 4e2c9da..388bfce 100644 (file)
@@ -423,7 +423,8 @@ enum {
 #define PHY_MODE_AC                            BIT(5)
 #define PHY_MODE_AX_24G                                BIT(6)
 #define PHY_MODE_AX_5G                         BIT(7)
-#define PHY_MODE_AX_6G                         BIT(8)
+
+#define PHY_MODE_AX_6G                         BIT(0) /* phymode_ext */
 
 #define MODE_CCK                               BIT(0)
 #define MODE_OFDM                              BIT(1)