i40iw: Remove check on return from device_init_pestat()

Remove unnecessary check for return code from
device_init_pestat() and change func to void.

Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Henry Orosco <henry.orosco@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
index 8417452..5dde358 100644 (file)
--- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c
@@ -4853,10 +4853,9 @@ static const struct i40iw_device_pestat_ops iw_device_pestat_ops = {
  * i40iw_device_init_pestat - Initialize the pestat structure
  * @dev: pestat struct
  */
-enum i40iw_status_code i40iw_device_init_pestat(struct i40iw_dev_pestat *devstat)
+void i40iw_device_init_pestat(struct i40iw_dev_pestat *devstat)
 {
        devstat->ops = iw_device_pestat_ops;
-       return 0;
 }
 
 /**
@@ -4881,12 +4880,7 @@ enum i40iw_status_code i40iw_device_init(struct i40iw_sc_dev *dev,
 
        dev->debug_mask = info->debug_mask;
 
-       ret_code = i40iw_device_init_pestat(&dev->dev_pestat);
-       if (ret_code) {
-               i40iw_debug(dev, I40IW_DEBUG_DEV,
-                           "%s: i40iw_device_init_pestat failed\n", __func__);
-               return ret_code;
-       }
+       i40iw_device_init_pestat(&dev->dev_pestat);
        dev->hmc_fn_id = info->hmc_fn_id;
        i40iw_fill_qos_list(info->l2params.qs_handle_list);
        for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {

diff --git a/drivers/infiniband/hw/i40iw/i40iw_p.h b/drivers/infiniband/hw/i40iw/i40iw_p.h
index c9e8cb8..2a4bd32 100644 (file)
--- a/drivers/infiniband/hw/i40iw/i40iw_p.h
+++ b/drivers/infiniband/hw/i40iw/i40iw_p.h
@@ -47,7 +47,7 @@ void i40iw_debug_buf(struct i40iw_sc_dev *dev, enum i40iw_debug_flag mask,
 enum i40iw_status_code i40iw_device_init(struct i40iw_sc_dev *dev,
                                         struct i40iw_device_init_info *info);
 
-enum i40iw_status_code i40iw_device_init_pestat(struct i40iw_dev_pestat *);
+void i40iw_device_init_pestat(struct i40iw_dev_pestat *devstat);
 
 void i40iw_sc_cqp_post_sq(struct i40iw_sc_cqp *cqp);
 

diff --git a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
index 3041003..dbd39c4 100644 (file)
--- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
@@ -496,11 +496,7 @@ enum i40iw_status_code i40iw_vchnl_recv_pf(struct i40iw_sc_dev *dev,
                                i40iw_debug(dev, I40IW_DEBUG_VIRT,
                                            "VF%u error CQP HMC Function operation.\n",
                                            vf_id);
-                       ret_code = i40iw_device_init_pestat(&vf_dev->dev_pestat);
-                       if (ret_code)
-                               i40iw_debug(dev, I40IW_DEBUG_VIRT,
-                                           "VF%u - i40iw_device_init_pestat failed\n",
-                                           vf_id);
+                       i40iw_device_init_pestat(&vf_dev->dev_pestat);
                        vf_dev->dev_pestat.ops.iw_hw_stat_init(&vf_dev->dev_pestat,
                                                              (u8)vf_dev->pmf_index,
                                                              dev->hw, false);