[Issue] N/A
[Problem] Signals are not disconnected on tab close
[Solution] Disconnect signals on tab closing
[Verify] 1. Open any page
2. Select word and open find on page from
context menu
-> Find on page should open
3. Go to tabs manager and close tab
4. Repeat steps 1 and 2
-> Find on page should open
Change-Id: I462177d564e65e025b103389c9b417dfc18de2af
closingTabId),
m_stateStruct->mostRecentTab.end());
- if (closingTabId == m_stateStruct->currentTabId) {
- if (m_currentWebView)
- m_currentWebView.reset();
- }
if (m_stateStruct->tabs.size() == 0) {
m_stateStruct->currentTabId = TabId::NONE;
+ if (m_currentWebView) {
+ disconnectSignals(m_currentWebView);
+ m_currentWebView.reset();
+ }
}
else if (closingTabId == m_stateStruct->currentTabId && m_stateStruct->mostRecentTab.size()){
res = switchToTab(m_stateStruct->mostRecentTab.back());