[HIP] Support flush denormals bitcode
authorAaron Enye Shi <enye.shi@gmail.com>
Wed, 27 Jun 2018 18:58:55 +0000 (18:58 +0000)
committerAaron Enye Shi <enye.shi@gmail.com>
Wed, 27 Jun 2018 18:58:55 +0000 (18:58 +0000)
Summary:
Use oclc_daz_opt_on.amdgcn.bc bitcode when option fcuda-flush-denormal-to-zero is enabled, otherwise use oclc_daz_opt_off.amdgcn.bc bitcode. Added lit tests to verify that the correct bitcode is linked when -fcuda-flush-denormal-to-zero option is enabled or disabled.

Reviewers: yaxunl, scchan, b-sumner

Reviewed By: yaxunl, scchan, b-sumner

Subscribers: cfe-commits, yaxunl

Differential Revision: https://reviews.llvm.org/D48493

llvm-svn: 335765

13 files changed:
clang/lib/Driver/ToolChains/HIP.cpp
clang/test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_off.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_on.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_finite_only_off.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_803.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_900.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/oclc_unsafe_math_off.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/ocml.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/Inputs/hip_dev_lib/opencl.amdgcn.bc [new file with mode: 0644]
clang/test/Driver/hip-device-libs.hip [new file with mode: 0644]

index 38dfb0e..2aa7cac 100644 (file)
@@ -75,10 +75,16 @@ const char *AMDGCN::Linker::constructLLVMLinkCommand(
     std::string ISAVerBC =
         "oclc_isa_version_" + SubArchName.drop_front(3).str() + ".amdgcn.bc";
 
+    llvm::StringRef FlushDenormalControlBC;
+    if (Args.hasArg(options::OPT_fcuda_flush_denormals_to_zero))
+      FlushDenormalControlBC = "oclc_daz_opt_on.amdgcn.bc";
+    else
+      FlushDenormalControlBC = "oclc_daz_opt_off.amdgcn.bc";
+
     BCLibs.append({"opencl.amdgcn.bc",
                    "ockl.amdgcn.bc", "irif.amdgcn.bc", "ocml.amdgcn.bc",
                    "oclc_finite_only_off.amdgcn.bc",
-                   "oclc_daz_opt_off.amdgcn.bc",
+                   FlushDenormalControlBC,
                    "oclc_correctly_rounded_sqrt_on.amdgcn.bc",
                    "oclc_unsafe_math_off.amdgcn.bc", ISAVerBC});
   }
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/irif.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/ockl.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_correctly_rounded_sqrt_on.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_off.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_off.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_on.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_daz_opt_on.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_finite_only_off.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_finite_only_off.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_803.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_803.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_900.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_isa_version_900.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/oclc_unsafe_math_off.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/oclc_unsafe_math_off.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/ocml.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/ocml.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/Inputs/hip_dev_lib/opencl.amdgcn.bc b/clang/test/Driver/Inputs/hip_dev_lib/opencl.amdgcn.bc
new file mode 100644 (file)
index 0000000..e69de29
diff --git a/clang/test/Driver/hip-device-libs.hip b/clang/test/Driver/hip-device-libs.hip
new file mode 100644 (file)
index 0000000..74a3e7b
--- /dev/null
@@ -0,0 +1,27 @@
+// REQUIRES: clang-driver
+// REQUIRES: x86-registered-target
+// REQUIRES: amdgpu-registered-target
+
+// Test flush-denormals-to-zero enabled uses oclc_daz_opt_on
+
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN:   -x hip --cuda-gpu-arch=gfx900 \
+// RUN:   --hip-device-lib-path=%S/Inputs/hip_dev_lib \
+// RUN:   -fcuda-flush-denormals-to-zero \
+// RUN:   %S/Inputs/hip_multiple_inputs/b.hip \
+// RUN: 2>&1 | FileCheck %s --check-prefixes=COM,FLUSHD
+
+// Test flush-denormals-to-zero disabled uses oclc_daz_opt_off
+
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN:   -x hip --cuda-gpu-arch=gfx900 \
+// RUN:   --hip-device-lib-path=%S/Inputs/hip_dev_lib \
+// RUN:   %S/Inputs/hip_multiple_inputs/b.hip \
+// RUN: 2>&1 | FileCheck %s --check-prefixes=COM,NOFLUSHD
+
+
+// COM: [[LLVM_LINK:"*.llvm-link"]]
+// FLUSHD-SAME: {{.*}} "{{.*}}oclc_daz_opt_on.amdgcn.bc"
+// NOFLUSHD-SAME: {{.*}} "{{.*}}oclc_daz_opt_off.amdgcn.bc"
+// COM-SAME: {{.*}} "-o" "{{.*}}-gfx900-linked-{{.*bc}}"
+