rtc: sunplus: Clean up redundant dev_err_probe()
authorChen Jiahao <chenjiahao16@huawei.com>
Wed, 2 Aug 2023 09:36:50 +0000 (17:36 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 10 Aug 2023 07:35:28 +0000 (09:35 +0200)
Referring to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.

Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Link: https://lore.kernel.org/r/20230802093650.976352-1-chenjiahao16@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-sunplus.c

index f33dc301f3019338bc344abbf04efa104bde7f19..20c7e97c2fc81523356dd0cb23d2fde02cd48be0 100644 (file)
@@ -244,7 +244,7 @@ static int sp_rtc_probe(struct platform_device *plat_dev)
 
        sp_rtc->irq = platform_get_irq(plat_dev, 0);
        if (sp_rtc->irq < 0)
-               return dev_err_probe(&plat_dev->dev, sp_rtc->irq, "platform_get_irq failed\n");
+               return sp_rtc->irq;
 
        ret = devm_request_irq(&plat_dev->dev, sp_rtc->irq, sp_rtc_irq_handler,
                               IRQF_TRIGGER_RISING, "rtc irq", plat_dev);