rtc: st-lpc: Release some resources in st_rtc_probe() in case of error
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 8 Jun 2023 19:11:42 +0000 (21:11 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:59 +0000 (16:21 +0200)
[ Upstream commit 06c6e1b01d9261f03629cefd1f3553503291e6cf ]

If an error occurs after clk_get(), the corresponding resources should be
released.

Use devm_clk_get() to fix it.

Fixes: b5b2bdfc2893 ("rtc: st: Add new driver for ST's LPC RTC")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/866af6adbc7454a7b4505eb6c28fbdc86ccff39e.1686251455.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-st-lpc.c

index 0f8e423..d04d46f 100644 (file)
@@ -228,7 +228,7 @@ static int st_rtc_probe(struct platform_device *pdev)
        enable_irq_wake(rtc->irq);
        disable_irq(rtc->irq);
 
-       rtc->clk = clk_get(&pdev->dev, NULL);
+       rtc->clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(rtc->clk)) {
                dev_err(&pdev->dev, "Unable to request clock\n");
                return PTR_ERR(rtc->clk);