tpm: remove redundant variable len
authorColin Ian King <colin.i.king@gmail.com>
Fri, 16 Jun 2023 17:07:30 +0000 (18:07 +0100)
committerJarkko Sakkinen <jarkko@kernel.org>
Thu, 17 Aug 2023 20:12:41 +0000 (20:12 +0000)
Variable len is being accumulated but the value is never read. It is
redundant and can be removed. Cleans up clang scan build warning:

drivers/char/tpm/eventlog/tpm1.c:276:2: warning: Value stored to 'len' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
drivers/char/tpm/eventlog/tpm1.c

index 8aa9057..12ee42a 100644 (file)
@@ -251,7 +251,6 @@ static int tpm1_binary_bios_measurements_show(struct seq_file *m, void *v)
 
 static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
 {
-       int len = 0;
        char *eventname;
        struct tcpa_event *event = v;
        unsigned char *event_entry =
@@ -273,7 +272,7 @@ static int tpm1_ascii_bios_measurements_show(struct seq_file *m, void *v)
        /* 3rd: event type identifier */
        seq_printf(m, " %02x", do_endian_conversion(event->event_type));
 
-       len += get_event_name(eventname, event, event_entry);
+       get_event_name(eventname, event, event_entry);
 
        /* 4th: eventname <= max + \'0' delimiter */
        seq_printf(m, " %s\n", eventname);