media: soc_camera: fix compiler warning
authorHans Verkuil <hans.verkuil@cisco.com>
Mon, 14 May 2018 13:09:37 +0000 (09:09 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 25 May 2018 19:34:04 +0000 (15:34 -0400)
In function 'strncpy',
    inlined from 'soc_camera_platform_probe' at drivers/media/platform/soc_camera/soc_camera_platform.c:162:2:
include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
  return __builtin_strncpy(p, q, size);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/soc_camera/soc_camera_platform.c

index cb4986b..ce00e90 100644 (file)
@@ -159,7 +159,8 @@ static int soc_camera_platform_probe(struct platform_device *pdev)
 
        v4l2_subdev_init(&priv->subdev, &platform_subdev_ops);
        v4l2_set_subdevdata(&priv->subdev, p);
-       strncpy(priv->subdev.name, dev_name(&pdev->dev), V4L2_SUBDEV_NAME_SIZE);
+       strlcpy(priv->subdev.name, dev_name(&pdev->dev),
+               sizeof(priv->subdev.name));
 
        return v4l2_device_register_subdev(&ici->v4l2_dev, &priv->subdev);
 }