Resharper warnings are slightly different for some reason than WError, resolve these...
authorJason Smith <jason.smith@xamarin.com>
Tue, 12 Apr 2016 00:33:34 +0000 (17:33 -0700)
committerJason Smith <jason.smith@xamarin.com>
Tue, 12 Apr 2016 00:33:34 +0000 (17:33 -0700)
21 files changed:
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-BoundViewUITest.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ClipToBoundsUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-EntryUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-GroupedListActionsUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-InputIntentUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ListUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-RelativeLayoutUITest.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SearchBarUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SliderUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StackLayoutUITest.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StepperUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SwitchUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TableViewUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedCarouselPageUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedTabPageUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-UnevenViewCellUITests.cs
Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ViewCellUITests.cs
Xamarin.Forms.Maps.iOS/MapRenderer.cs
Xamarin.Forms.Platform.Android/Renderers/ImageExtensions.cs
Xamarin.Forms.Platform.WinRT/Platform.cs
Xamarin.Forms.Platform.iOS/Renderers/CarouselViewRenderer.cs

index 625a27c..4f2a733 100644 (file)
@@ -52,9 +52,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.WaitForElement (q => q.Marked ("Second Page"), "Timeout : Second Page");
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 
 //             [Test]
 //             [Description ("Verify all elements are preset - landscape")]
index 9dffeaa..b6a8ebc 100644 (file)
@@ -42,10 +42,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.Screenshot ("Clip elements");
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Check all elements exist - landscape")]
 //             public void ClipToBoundsGalleryAllElementsExistLandscape ()
index e88ff6b..d3fc890 100644 (file)
@@ -213,10 +213,6 @@ namespace Xamarin.Forms.Core.UITests
 //             }
                        
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("All Entry Gallery elements are present - landscape")]
 //             public void EntryGalleryAllElementsPresentLandscape ()
index 289b538..374e063 100644 (file)
@@ -178,10 +178,6 @@ namespace Xamarin.Forms.Core.UITests
 
 //             }
                        
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Child item action test - landscape")]
 //             public void GroupedListActionsGalleryAllElementsExistLandscape ()
index 1071308..8a0bb96 100644 (file)
@@ -136,10 +136,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     }
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("All entries are shown - landscape")]
 //             public void InputIntentGalleryAllElementsExistLandscape ()
index e57ed90..17fb1eb 100644 (file)
@@ -62,10 +62,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.Screenshot ("At the bottom of the list");
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Click 0 - 5 and reset - Landscape")]
 //             public void ListGalleryClickElementsAndResetLandscape ()
index 72171f3..caa05ea 100644 (file)
@@ -30,10 +30,6 @@ namespace Xamarin.Forms.Core.UITests
 //                             App.ScrollDownForElement (q => q.Marked (element.ToString ()), 10);
                }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("All elements are present - Landscape")]
 //             public void RelativeLayoutGalleryAllElementsPresentLandscape ()
index d9461cf..399a446 100644 (file)
@@ -110,9 +110,6 @@ namespace Xamarin.Forms.Core.UITests
 
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 //             [Test]
 //             [Category ("ManualReview")]
 //             [Description ("Enable disable keyboard, Issues #1182, #1237 - landscape")]
index 11c33d7..ae2754d 100644 (file)
@@ -65,10 +65,6 @@ namespace Xamarin.Forms.Core.UITests
 
                }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             public void AllElementsPresentLandscape ()
 //             {
index b17c7ec..9f6d6d3 100644 (file)
@@ -58,9 +58,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.Screenshot ("All buttons clicked");
                }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 //             [Test]
 //             [Description ("Check that each button is there and click them - Landscape")]
 //             public void StackLayoutGalleryClickEachButtonLandscape ()
index a468e31..aaf5f0e 100644 (file)
@@ -62,10 +62,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     }
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Check all elements exist - Landscape")]
 //             public void StepperGalleryAllElementsPresetLandscape ()
index 67a23d8..c2eb1ab 100644 (file)
@@ -73,10 +73,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     }
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Check all elements exist - Landscape")]
 //             public void SwitchGalleryAllElementsPresetLandscape ()
index 5f9bd80..1f1dd01 100644 (file)
@@ -45,10 +45,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.Screenshot ("TableCells are present");
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Elements of CustomHeader are present - Landscape")]
 //             public void TableViewGalleryCustomHeaderLandscape ()
index f01641a..47e3445 100644 (file)
@@ -300,9 +300,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     ScrollUpForQuery (q => q.Marked (title), scrollContainerBounds);
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 
 //             [Test]
 //             [Description ("Insert page - Landscape")]
index 180c7bf..36d051b 100644 (file)
@@ -250,10 +250,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.DragFromToForElement (2, query, screenBounds.Width - 10, screenBounds.Height / 3.0f, screenBounds.Width - 10,  (2 / 3.0f) * screenBounds.Height);
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("Insert tab - Landscape")]
 //             public void TemplatedTabPageGalleryInsertTabLandscape () 
index 1b826ec..1cab2a1 100644 (file)
@@ -64,10 +64,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     Assert.Greater (unevenCellHeight, evenCellHeight);
 //             }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("All views exist - Landscape")]
 //             public void UnevenViewCellGalleryScrollDownForAllElementsLandscape ()
index c6a79e7..1dcc0de 100644 (file)
@@ -47,10 +47,6 @@ namespace Xamarin.Forms.Core.UITests
 //                     App.Screenshot ("All ViewCells exist");
                }
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //             [Test]
 //             [Description ("All elements exist - Landscape")]
 //             public void ViewCellGalleryScrollDownForAllElementsLandscape ()
index aa3bb44..94d5eee 100644 (file)
@@ -133,8 +133,7 @@ namespace Xamarin.Forms.Maps.iOS
 
        public class MapRenderer : ViewRenderer
        {
-               long _handle = 0;
-               CLLocationManager _locationManager;
+           CLLocationManager _locationManager;
 
                public override SizeRequest GetDesiredSize(double widthConstraint, double heightConstraint)
                {
index e48682c..7ae3d28 100644 (file)
@@ -19,7 +19,6 @@ namespace Xamarin.Forms.Platform.Android
                                default:
                                case Aspect.AspectFit:
                                        return s_aspectFit ?? (s_aspectFit = ImageView.ScaleType.FitCenter);
-                                       ;
                        }
                }
        }
index df16ddc..dbef5f7 100644 (file)
@@ -342,7 +342,9 @@ namespace Xamarin.Forms.Platform.WinRT
                readonly ToolbarTracker _toolbarTracker = new ToolbarTracker();
                readonly FileImageSourcePathConverter _fileImageSourcePathConverter = new FileImageSourcePathConverter();
 
-               IToolbarProvider _toolbarProvider;
+#pragma warning disable 649
+        IToolbarProvider _toolbarProvider;
+#pragma warning restore 649
 
                class ToolbarProvider : IToolbarProvider
                {
index d52feb7..84f57a9 100644 (file)
@@ -38,7 +38,9 @@ namespace Xamarin.Forms.Platform.iOS
        ///     The interfaces only implement required method while the UICollectionView exposes optional methods via
        ///     ExportAttribute.
        ///     The C# method name may be aliased. For example, C# "GetCell" maps to obj-C "CellForItemAtIndexPath".
+#pragma warning disable 1584
        ///     <seealso cref="https://developer.apple.com/library/ios/documentation/UIKit/Reference/UICollectionView_class/" />
+#pragma warning restore 1584
        /// </summary>
        public class CarouselViewRenderer : ViewRenderer<CarouselView, UICollectionView>
        {