rpmsg: virtio: Fix the unregistration of the device rpmsg_ctrl
authorArnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Tue, 26 Apr 2022 06:05:36 +0000 (14:05 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Tue, 26 Apr 2022 15:27:15 +0000 (09:27 -0600)
Unregister the rpmsg_ctrl device instead of just freeing the
the virtio_rpmsg_channel structure.
This will properly unregister the device and call
virtio_rpmsg_release_device() that frees the structure.

Fixes: c486682ae1e2 ("rpmsg: virtio: Register the rpmsg_char device")
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Reviewed-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20220426060536.15594-4-hbh25y@gmail.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/rpmsg/virtio_rpmsg_bus.c

index 9948a73..905ac79 100644 (file)
@@ -862,7 +862,7 @@ static void rpmsg_virtio_del_ctrl_dev(struct rpmsg_device *rpdev_ctrl)
 {
        if (!rpdev_ctrl)
                return;
-       kfree(to_virtio_rpmsg_channel(rpdev_ctrl));
+       device_unregister(&rpdev_ctrl->dev);
 }
 
 static int rpmsg_probe(struct virtio_device *vdev)