media: stk1160: Fixed high volume of stk1160_dbg messages
authorGhanshyam Agrawal <ghanshyam1898@gmail.com>
Sat, 25 Nov 2023 09:02:36 +0000 (14:32 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:27 +0000 (20:14 +0000)
[ Upstream commit b3695e86d25aafbe175dd51f6aaf6f68d341d590 ]

The function stk1160_dbg gets called too many times, which causes
the output to get flooded with messages. Since stk1160_dbg uses
printk, it is now replaced with printk_ratelimited.

Suggested-by: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Ghanshyam Agrawal <ghanshyam1898@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/stk1160/stk1160-video.c

index 4e966f6..366f0e4 100644 (file)
@@ -107,8 +107,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
 
        /*
         * TODO: These stk1160_dbg are very spammy!
-        * We should 1) check why we are getting them
-        * and 2) add ratelimit.
+        * We should check why we are getting them.
         *
         * UPDATE: One of the reasons (the only one?) for getting these
         * is incorrect standard (mismatch between expected and configured).
@@ -151,7 +150,7 @@ void stk1160_copy_video(struct stk1160 *dev, u8 *src, int len)
 
        /* Let the bug hunt begin! sanity checks! */
        if (lencopy < 0) {
-               stk1160_dbg("copy skipped: negative lencopy\n");
+               printk_ratelimited(KERN_DEBUG "copy skipped: negative lencopy\n");
                return;
        }