Fix NotSupported condition in dEQP_VK.spirv_assembly
authorSlawomir Cygan <slawomir.cygan@intel.com>
Wed, 4 Oct 2017 14:24:18 +0000 (16:24 +0200)
committerSlawomir Cygan <slawomir.cygan@intel.com>
Wed, 4 Oct 2017 14:26:24 +0000 (16:26 +0200)
The API version check was backwards.

Affects:
dEQP_VK.spirv_assembly.*

Components: Vulkan
VK-GL-CTS issue: 740

Change-Id: Ic5e2bfbdbd202c4b27295573cdeca1ea06424c7c

external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmComputeShaderCase.cpp
external/vulkancts/modules/vulkan/spirv_assembly/vktSpvAsmGraphicsShaderTestUtil.cpp

index adcf0d4..f68ebb7 100644 (file)
@@ -283,9 +283,9 @@ void SpvAsmComputeShaderCase::initPrograms (SourceCollections& programCollection
 
 TestInstance* SpvAsmComputeShaderCase::createInstance (Context& ctx) const
 {
-       if (getMinRequiredVulkanVersion(m_shaderSpec.spirvVersion) < ctx.getUsedApiVersion())
+       if (getMinRequiredVulkanVersion(m_shaderSpec.spirvVersion) > ctx.getUsedApiVersion())
        {
-               TCU_THROW(NotSupportedError, std::string("Vulkan higher than " + getVulkanName(ctx.getUsedApiVersion()) + " is required for this test to run").c_str());
+               TCU_THROW(NotSupportedError, std::string("Vulkan higher than or equal to " + getVulkanName(getMinRequiredVulkanVersion(m_shaderSpec.spirvVersion)) + " is required for this test to run").c_str());
        }
        return new SpvAsmComputeShaderInstance(ctx, m_shaderSpec, m_features);
 }
index 96c1405..a4a79d8 100644 (file)
@@ -2204,9 +2204,9 @@ Move<VkBuffer> createBufferForResource(const DeviceInterface& vk, const VkDevice
 
 TestStatus runAndVerifyDefaultPipeline (Context& context, InstanceContext instance)
 {
-       if (getMinRequiredVulkanVersion(instance.resources.spirvVersion) < context.getUsedApiVersion())
+       if (getMinRequiredVulkanVersion(instance.resources.spirvVersion) > context.getUsedApiVersion())
        {
-               TCU_THROW(NotSupportedError, string("Vulkan higher than " + getVulkanName(context.getUsedApiVersion()) + " is required for this test to run").c_str());
+               TCU_THROW(NotSupportedError, string("Vulkan higher than or equal to " + getVulkanName(getMinRequiredVulkanVersion(instance.resources.spirvVersion)) + " is required for this test to run").c_str());
        }
 
        const InstanceInterface&                                        vkInstance                              = context.getInstanceInterface();