Handle return value from __get_shared_dir() properly 84/175584/1
authorSemun Lee <semun.lee@samsung.com>
Tue, 10 Apr 2018 23:47:18 +0000 (08:47 +0900)
committerSemun Lee <semun.lee@samsung.com>
Tue, 10 Apr 2018 23:47:18 +0000 (08:47 +0900)
returning NULL is not an out of memory case sometimes.

Change-Id: Idcab45dbd71a0465dd5f223077ee09ae51dd8396
Signed-off-by: Semun Lee <semun.lee@samsung.com>
src/notification_shared_file.c

index 84bb881c79770378715dc4e75cea48a3c0352991..cd2cc81a51cf893cbd8e6617111b2e3dc8fe2daf 100644 (file)
@@ -1002,8 +1002,10 @@ EXPORT_API int notification_set_private_sharing(notification_h noti,
                                                __free_req_info(req_data));
 
                req_data->dir = __get_shared_dir(noti);
-               __OOM_CHECK(req_data->dir, NOTIFICATION_ERROR_OUT_OF_MEMORY,
-                                               __free_req_info(req_data));
+               if (req_data->dir == NULL) {
+                       __free_req_info(req_data);
+                       return NOTIFICATION_ERROR_INVALID_PARAMETER;
+               }
 
                uid_info->sharing_req_list = g_list_append(
                        uid_info->sharing_req_list, req_data);