perf stat: Split print_noise_pct() function
authorNamhyung Kim <namhyung@kernel.org>
Mon, 14 Nov 2022 23:02:11 +0000 (15:02 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 16 Nov 2022 12:51:22 +0000 (09:51 -0300)
Likewise, split print_noise_pct() for each output mode.  Although it's
a tiny function, more logic will be added soon so it'd be better split
it and treat it in the same way.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Xing Zhengjun <zhengjun.xing@linux.intel.com>
Link: https://lore.kernel.org/r/20221114230227.1255976-4-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/stat-display.c

index 281b811..a230f65 100644 (file)
@@ -62,17 +62,36 @@ static void print_running(struct perf_stat_config *config,
                print_running_std(config, run, ena);
 }
 
+static void print_noise_pct_std(struct perf_stat_config *config,
+                               double pct)
+{
+       if (pct)
+               fprintf(config->output, "  ( +-%6.2f%% )", pct);
+}
+
+static void print_noise_pct_csv(struct perf_stat_config *config,
+                               double pct)
+{
+       fprintf(config->output, "%s%.2f%%", config->csv_sep, pct);
+}
+
+static void print_noise_pct_json(struct perf_stat_config *config,
+                                double pct)
+{
+       fprintf(config->output, "\"variance\" : %.2f, ", pct);
+}
+
 static void print_noise_pct(struct perf_stat_config *config,
                            double total, double avg)
 {
        double pct = rel_stddev_stats(total, avg);
 
        if (config->json_output)
-               fprintf(config->output, "\"variance\" : %.2f, ", pct);
+               print_noise_pct_json(config, pct);
        else if (config->csv_output)
-               fprintf(config->output, "%s%.2f%%", config->csv_sep, pct);
-       else if (pct)
-               fprintf(config->output, "  ( +-%6.2f%% )", pct);
+               print_noise_pct_csv(config, pct);
+       else
+               print_noise_pct_std(config, pct);
 }
 
 static void print_noise(struct perf_stat_config *config,