staging:rtl8192u: Remove proxy array rtl819XAGCTAB_Array - Style
authorJohn Whitmore <johnfwhitmore@gmail.com>
Thu, 26 Jul 2018 19:24:18 +0000 (20:24 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Jul 2018 08:13:26 +0000 (10:13 +0200)
Remove the array rtl819XAGCTAB_Array which is only a proxy to the
array Rtl8192UsbAGCTAB_Array. There appears to be no purpose
served by this implementation, other then to obscure the
Rtl8192UsbAGCTAB_Array structure, which is actually written to and
read from.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/r819xU_phy.c
drivers/staging/rtl8192u/r819xU_phy.h

index 8d44bbe..cf7b09f 100644 (file)
@@ -33,7 +33,6 @@ static u32 RF_CHANNEL_TABLE_ZEBRA[] = {
 #define rtl819XRadioB_Array Rtl8192UsbRadioB_Array
 #define rtl819XRadioC_Array Rtl8192UsbRadioC_Array
 #define rtl819XRadioD_Array Rtl8192UsbRadioD_Array
-#define rtl819XAGCTAB_Array Rtl8192UsbAGCTAB_Array
 
 /******************************************************************************
  * function:  This function checks different RF type to execute legal judgement.
@@ -542,12 +541,12 @@ void rtl8192_phyConfigBB(struct net_device *dev, u8 ConfigType)
                }
        } else if (ConfigType == BaseBand_Config_AGC_TAB) {
                for (i = 0; i < AGCTAB_ArrayLength; i += 2) {
-                       rtl8192_setBBreg(dev, rtl819XAGCTAB_Array[i],
-                                        bMaskDWord, rtl819XAGCTAB_Array[i+1]);
+                       rtl8192_setBBreg(dev, Rtl8192UsbAGCTAB_Array[i],
+                                        bMaskDWord, Rtl8192UsbAGCTAB_Array[i+1]);
                        RT_TRACE(COMP_DBG,
-                                "i: %x, rtl819XAGCTAB_Array[0]=%x rtl819XAGCTAB_Array[1]=%x\n",
-                                i, rtl819XAGCTAB_Array[i],
-                                rtl819XAGCTAB_Array[i+1]);
+                                "i: %x, Rtl8192UsbAGCTAB_Array[0]=%x Rtl8192UsbAGCTAB_Array[1]=%x\n",
+                                i, Rtl8192UsbAGCTAB_Array[i],
+                                Rtl8192UsbAGCTAB_Array[i+1]);
                }
        }
 }
index 842837b..808a11c 100644 (file)
@@ -25,7 +25,6 @@ struct sw_chnl_cmd {
        u32                     ms_delay;
 } __packed;
 
-extern u32 rtl819XAGCTAB_Array[];
 extern u32 rtl819XRadioA_Array[];
 extern u32 rtl819XRadioB_Array[];
 extern u32 rtl819XRadioC_Array[];