mlxsw: spectrum_router: FIB: Use tracker helpers to hold & put netdevices

Using the tracking helpers makes it easier to debug netdevice refcount
imbalances when CONFIG_NET_DEV_REFCNT_TRACKER is enabled.

Convert dev_hold() / dev_put() to netdev_hold() / netdev_put() in the
router code that deals with FIB events.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/5221a92e751c40447c55959f622267ccc999ed04.1690471774.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 57f0faa..0744497 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -7547,6 +7547,7 @@ struct mlxsw_sp_fib6_event_work {
 
 struct mlxsw_sp_fib_event_work {
        struct work_struct work;
+       netdevice_tracker dev_tracker;
        union {
                struct mlxsw_sp_fib6_event_work fib6_work;
                struct fib_entry_notifier_info fen_info;
@@ -7720,12 +7721,12 @@ static void mlxsw_sp_router_fibmr_event_work(struct work_struct *work)
                                                    &fib_work->ven_info);
                if (err)
                        dev_warn(mlxsw_sp->bus_info->dev, "MR VIF add failed.\n");
-               dev_put(fib_work->ven_info.dev);
+               netdev_put(fib_work->ven_info.dev, &fib_work->dev_tracker);
                break;
        case FIB_EVENT_VIF_DEL:
                mlxsw_sp_router_fibmr_vif_del(mlxsw_sp,
                                              &fib_work->ven_info);
-               dev_put(fib_work->ven_info.dev);
+               netdev_put(fib_work->ven_info.dev, &fib_work->dev_tracker);
                break;
        }
        mutex_unlock(&mlxsw_sp->router->lock);
@@ -7796,7 +7797,8 @@ mlxsw_sp_router_fibmr_event(struct mlxsw_sp_fib_event_work *fib_work,
        case FIB_EVENT_VIF_ADD:
        case FIB_EVENT_VIF_DEL:
                memcpy(&fib_work->ven_info, info, sizeof(fib_work->ven_info));
-               dev_hold(fib_work->ven_info.dev);
+               netdev_hold(fib_work->ven_info.dev, &fib_work->dev_tracker,
+                           GFP_ATOMIC);
                break;
        }
 }