ceph: return ceph_mdsc_do_request() errors from __get_parent()
authorQiujun Huang <hqjagain@gmail.com>
Fri, 6 Mar 2020 01:34:20 +0000 (09:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 2 May 2020 15:23:03 +0000 (17:23 +0200)
[ Upstream commit c6d50296032f0b97473eb2e274dc7cc5d0173847 ]

Return the error returned by ceph_mdsc_do_request(). Otherwise,
r_target_inode ends up being NULL this ends up returning ENOENT
regardless of the error.

Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ceph/export.c

index 1780218a48f0843e2fa0777831d958cb4c4e9a37..f8e1f31e46439047866154e5981c22dcc1294092 100644 (file)
@@ -157,6 +157,11 @@ static struct dentry *__get_parent(struct super_block *sb,
 
        req->r_num_caps = 1;
        err = ceph_mdsc_do_request(mdsc, NULL, req);
+       if (err) {
+               ceph_mdsc_put_request(req);
+               return ERR_PTR(err);
+       }
+
        inode = req->r_target_inode;
        if (inode)
                ihold(inode);