wifi: wilc1000: fix potential memory leak in wilc_mac_xmit()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Thu, 17 Nov 2022 11:36:03 +0000 (19:36 +0800)
committerKalle Valo <kvalo@kernel.org>
Thu, 22 Dec 2022 16:05:57 +0000 (18:05 +0200)
The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
dev_kfree_skb() to fix it. Compile tested only.

Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/1668684964-48622-1-git-send-email-zhangchangzhong@huawei.com
drivers/net/wireless/microchip/wilc1000/netdev.c

index 9b319a4..6f3ae0d 100644 (file)
@@ -730,6 +730,7 @@ netdev_tx_t wilc_mac_xmit(struct sk_buff *skb, struct net_device *ndev)
 
        if (skb->dev != ndev) {
                netdev_err(ndev, "Packet not destined to this device\n");
+               dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }