elm widget - fix possible null ptr access found by coverity
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 28 Sep 2017 04:39:35 +0000 (13:39 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 28 Sep 2017 06:28:00 +0000 (15:28 +0900)
_propagate_event_legacy checked event_flags ptr for null then just
derefs it anyway... so check everywhere. fixes CID 1379920

src/lib/elementary/elm_widget.c

index 45c2864..85788bd 100644 (file)
@@ -1109,8 +1109,11 @@ _propagate_event_legacy(Eo *parent, const Efl_Event *event, Eo *obj, Elm_Event_C
    if (ecd->func((void *)ecd->data, parent, obj, type, event_info.any) ||
        (event_flags && ((*event_flags) & EVAS_EVENT_FLAG_ON_HOLD)))
      {
-        if (prev_flags != *event_flags)
-          efl_input_event_flags_set(event->info, *event_flags);
+        if (event_flags)
+          {
+             if (prev_flags != *event_flags)
+               efl_input_event_flags_set(event->info, *event_flags);
+          }
         return EINA_TRUE;
      }