crypto: stm32 - use of_device_get_match_data
authorCorentin LABBE <clabbe.montjoie@gmail.com>
Wed, 20 Sep 2017 18:31:40 +0000 (20:31 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 7 Oct 2017 04:10:34 +0000 (12:10 +0800)
The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it prevents an improbable dereference when
of_match_device() return NULL.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/stm32/stm32-hash.c

index b34ee85..fd13838 100644 (file)
@@ -1407,11 +1407,10 @@ MODULE_DEVICE_TABLE(of, stm32_hash_of_match);
 static int stm32_hash_get_of_match(struct stm32_hash_dev *hdev,
                                   struct device *dev)
 {
-       const struct of_device_id *match;
        int err;
 
-       match = of_match_device(stm32_hash_of_match, dev);
-       if (!match) {
+       hdev->pdata = of_device_get_match_data(dev);
+       if (!hdev->pdata) {
                dev_err(dev, "no compatible OF match\n");
                return -EINVAL;
        }
@@ -1419,8 +1418,6 @@ static int stm32_hash_get_of_match(struct stm32_hash_dev *hdev,
        err = of_property_read_u32(dev->of_node, "dma-maxburst",
                                   &hdev->dma_maxburst);
 
-       hdev->pdata = match->data;
-
        return err;
 }