serial: pmac_zilog: add sparse context annotation
authorJohan Hovold <johan@kernel.org>
Thu, 23 Jul 2020 12:33:26 +0000 (14:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2020 08:44:27 +0000 (10:44 +0200)
Add sparse context annotation to the receive handler, which releases and
reacquires the port lock, to silence a sparse warning:

drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200723123327.5843-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pmac_zilog.c

index ba65a3b..96e7aa4 100644 (file)
@@ -213,6 +213,7 @@ static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable)
 }
 
 static bool pmz_receive_chars(struct uart_pmac_port *uap)
+       __must_hold(&uap->port.lock)
 {
        struct tty_port *port;
        unsigned char ch, r1, drop, flag;