ext4: fix buffer leak in __ext4_read_dirblock() on error path
authorVasily Averin <vvs@virtuozzo.com>
Thu, 8 Nov 2018 03:36:23 +0000 (22:36 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 8 Nov 2018 03:36:23 +0000 (22:36 -0500)
Fixes: dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 3.9
fs/ext4/namei.c

index d388cce..6a6b903 100644 (file)
@@ -126,6 +126,7 @@ static struct buffer_head *__ext4_read_dirblock(struct inode *inode,
        if (!is_dx_block && type == INDEX) {
                ext4_error_inode(inode, func, line, block,
                       "directory leaf block found instead of index block");
+               brelse(bh);
                return ERR_PTR(-EFSCORRUPTED);
        }
        if (!ext4_has_metadata_csum(inode->i_sb) ||