firmware: Remove ALIGN in .rela.dyn in linker script

The .rela.dyn section should be exactly the size of the relocations,
without padding. On RV64, .rela* sections are already aligned and
there's no need for padding. On RV32, this adds padding up to 4 bytes,
which, if present, confuses the relocation loop into processing an extra
entry past the end of .rela*, and it crashes with an invalid memory
access.

Fixes: 0f20e8adcf42 ("firmware: Support position independent execution")
Signed-off-by: Vivian Wang <dramforever@live.com>
Reviewed-by: Anup Patel <anup@brainfault.org>

diff --git a/firmware/fw_base.ldS b/firmware/fw_base.ldS
index 3d68484ba5e37773af24d01d935b76338c0afafe..88b8dfd9cb56ce555efff900db6018f44b3ae6b5 100644 (file)
--- a/firmware/fw_base.ldS
+++ b/firmware/fw_base.ldS
@@ -49,7 +49,6 @@
        .rela.dyn : {
                PROVIDE(__rel_dyn_start = .);
                *(.rela*)
-               . = ALIGN(8);
                PROVIDE(__rel_dyn_end = .);
        }