drm/rockchip: vop2: Register Esmart0-win0 as primary plane
authorSascha Hauer <s.hauer@pengutronix.de>
Mon, 26 Sep 2022 08:16:43 +0000 (10:16 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Sat, 29 Oct 2022 16:34:51 +0000 (18:34 +0200)
Esmart0-win0 could serve as primary plane, so mark it as such. On
RK3568 this window will never be used as primary plane, because the
three windows at the beginning of the rk3568_vop_win_data[] array
will be used. On RK3566 however, two of the windows at the beginning
of the rk3568_vop_win_data[] array cannot not be used due to hardware
limitations, so without this patch we end up with CRTCs without primary
planes when multiple VPs are active.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Tested-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220926081643.304759-1-s.hauer@pengutronix.de
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c

index 9bf0637bf8e26dc54ed0ff5707f40f8f584ef4ba..9d30aa73b54222595ae7aad417bbb74cedf25ce5 100644 (file)
@@ -188,7 +188,7 @@ static const struct vop2_win_data rk3568_vop_win_data[] = {
                .base = 0x1800,
                .layer_sel_id = 2,
                .supported_rotations = DRM_MODE_REFLECT_Y,
-               .type = DRM_PLANE_TYPE_OVERLAY,
+               .type = DRM_PLANE_TYPE_PRIMARY,
                .max_upscale_factor = 8,
                .max_downscale_factor = 8,
                .dly = { 20, 47, 41 },