drm/i915/dsi: Ensure that the ACPI adapter lookup overrides the bus num
authorVivek Kasireddy <vivek.kasireddy@intel.com>
Sat, 18 Jan 2020 00:58:48 +0000 (16:58 -0800)
committerJani Nikula <jani.nikula@intel.com>
Fri, 24 Jan 2020 12:00:56 +0000 (14:00 +0200)
Remove the i2c_bus_num >= 0 check from the adapter lookup function
as this would prevent ACPI bus number override. This check was mainly
there to return early if the bus number has already been found but we
anyway return in the next line if the slave address does not match.

Fixes: 8cbf89db2941 ("drm/i915/dsi: Parse the I2C element from the VBT MIPI sequence block (v3)")
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Nabendu Maiti <nabendu.bikash.maiti@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200118005848.20382-1-vivek.kasireddy@intel.com
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 6ec35d9..04f953b 100644 (file)
@@ -394,8 +394,7 @@ static int i2c_adapter_lookup(struct acpi_resource *ares, void *data)
        acpi_handle adapter_handle;
        acpi_status status;
 
-       if (intel_dsi->i2c_bus_num >= 0 ||
-           !i2c_acpi_get_i2c_resource(ares, &sb))
+       if (!i2c_acpi_get_i2c_resource(ares, &sb))
                return 1;
 
        if (lookup->slave_addr != sb->slave_address)